Fix: Only add/remove successful items from a collection when specifying workflow#3256
Merged
Fix: Only add/remove successful items from a collection when specifying workflow#3256
Conversation
ikreymer
approved these changes
Apr 7, 2026
Member
ikreymer
left a comment
ikreymer
left a comment
There was a problem hiding this comment.
Update looks good, and good to have tests updated as well!
SuaYoo
approved these changes
Apr 15, 2026
github-project-automation
bot
moved this from In Review
to Done!
in Webrecorder Projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #3228 to ensure that only successful crawls are added or removed from a collection when specifying a workflow id in the collection
/addand/removeendpoints.Tests are modified to cover the case of failed crawls as well.
Related to #3254